This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
reviewed
Jun 5, 2017
"""Given a dotted path in the format ``class_name`` or | ||
``class_name:method_name`` this performs an alias lookup. For | ||
methods the line number must be supplied or the result is | ||
unreliaable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*unreliable
HazAT
suggested changes
Jun 5, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
HazAT
reviewed
Jun 5, 2017
class ProguardView(object): | ||
|
||
def __init__(self): | ||
raise TypeError('Cannot instanciate proguard views') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*instantiate
This refs getsentry/sentry-java#317 |
HazAT
approved these changes
Jun 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for proguard to libsourcemap. This is based on the rust library here: https://github.com/mitsuhiko/proguard