Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Add proguard support #10

Merged
merged 4 commits into from Jun 7, 2017
Merged

Add proguard support #10

merged 4 commits into from Jun 7, 2017

Conversation

mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Jun 5, 2017

This adds support for proguard to libsourcemap. This is based on the rust library here: https://github.com/mitsuhiko/proguard

@mitsuhiko mitsuhiko requested review from HazAT and tkaemming June 5, 2017 14:30
"""Given a dotted path in the format ``class_name`` or
``class_name:method_name`` this performs an alias lookup. For
methods the line number must be supplied or the result is
unreliaable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*unreliable

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

class ProguardView(object):

def __init__(self):
raise TypeError('Cannot instanciate proguard views')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*instantiate

@mitsuhiko
Copy link
Member Author

This refs getsentry/sentry-java#317

@mitsuhiko mitsuhiko merged commit 1f2f949 into master Jun 7, 2017
@mitsuhiko mitsuhiko deleted the feature/proguard branch June 7, 2017 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants