Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Set a theme-color via meta-tag or manifest #23289

Closed
frame opened this issue Jan 25, 2021 · 2 comments
Closed

Feature Request: Set a theme-color via meta-tag or manifest #23289

frame opened this issue Jan 25, 2021 · 2 comments

Comments

@frame
Copy link

frame commented Jan 25, 2021

Summary

Setting a theme-color via meta-tag or manifest would make the "PWA" version of Sentry to match the color-scheme of Sentry itself.

Motivation

When users run Sentry as PWA, the theme-color (title bar and background of the favicon) gets automatically defined by the browser, which is red in my MS Edge version (I suspect this might differ depending on the browser). Setting a theme-color <meta name="theme-color" content="#452650">, would make the window look much nicer. (see screenshot of the current red situation)

Additional Context

The actual colour could maybe get populated by the color-scheme itself or accept a setting via config.yml. The colour can get set via theme-color meta-tag or manifest.js

capture_20210125_131837

I'm currently using a workaround to inject the appropriate header tag at my proxy server (but this also disables compression)

<location />
    ProxyPass […]
    ProxyPassReverse […]
    RequestHeader unset Accept-Encoding
    AddOutputFilterByType SUBSTITUTE text/html
    Substitute "s|</head>|<meta name=\"theme-color\" content=\"#452650\"></head>|ni"
</location>

References

@frame frame changed the title Set a theme-color via meta-tag or manifest Feature Request: Set a theme-color via meta-tag or manifest Jan 25, 2021
@BYK BYK reopened this Jan 25, 2021
@BYK BYK transferred this issue from getsentry/self-hosted Jan 25, 2021
@getsentry getsentry deleted a comment from github-actions bot Jan 25, 2021
@billyvg billyvg assigned robinrendle and unassigned billyvg Jan 25, 2021
@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@billyvg
Copy link
Member

billyvg commented Feb 15, 2021

Thanks @frame!

Closed by #23675

@billyvg billyvg closed this as completed Feb 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants