fix(relay): Increase Kafka message size limit to 50MB #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect to store event, failing with with kafka error "Broker: Message size too large"
jan-auer
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Good catch, and thanks! That will work. If you like, you can also try much smaller limits like 2MB.
Attachments are chunked up into 1MB chunks before posting them into Kafka, but there is some meta data added into each message. The same goes for events. This causes the message to get slightly larger than 1MB but not much.
BYK
changed the title
BYK
pushed a commit
that referenced
this pull request
Jun 17, 2020
Based on my forum post https://forum.sentry.io/t/sentry-native-and-kafka-messagesizetoolarge-error/9948 In short I tried to send minidumps more than 1mb(in fact 2mb), and relay service failed to store event, with kafka error `MessageSizeTooLarge`. You can reproduce this if you recreate install this on local machine, create simple native project, and send minidump file more than 1mb via curl like suggested in docs or in web ui. And check the logs. I reason selected value of 50mb on https://github.com/getsentry/onpremise/blob/master/docker-compose.yml#L87, like you already hardcoded on kafka service.
MaicolBen
pushed a commit
to hinthealth/onpremise
that referenced
this pull request
Jul 20, 2020
Based on my forum post https://forum.sentry.io/t/sentry-native-and-kafka-messagesizetoolarge-error/9948 In short I tried to send minidumps more than 1mb(in fact 2mb), and relay service failed to store event, with kafka error `MessageSizeTooLarge`. You can reproduce this if you recreate install this on local machine, create simple native project, and send minidump file more than 1mb via curl like suggested in docs or in web ui. And check the logs. I reason selected value of 50mb on https://github.com/getsentry/onpremise/blob/master/docker-compose.yml#L87, like you already hardcoded on kafka service.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my forum post https://forum.sentry.io/t/sentry-native-and-kafka-messagesizetoolarge-error/9948
In short I tried to send minidumps more than 1mb(in fact 2mb), and relay service failed to store event, with kafka error
MessageSizeTooLarge.You can reproduce this if you recreate install this on local machine, create simple native project, and send minidump file more than 1mb via curl like suggested in docs or in web ui. And check the logs.
I reason selected value of 50mb on https://github.com/getsentry/onpremise/blob/master/docker-compose.yml#L87, like you already hardcoded on kafka service.