Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn for missing docs of public types #52

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Warn for missing docs of public types #52

merged 1 commit into from
Sep 6, 2019

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Sep 3, 2019 •
edited
Loading

Enables warn(missing_docs) for the entire crate to ensure that new interfaces are documented properly. The only exception is tpi/data.rs -- too many comments are missing there.

@jan-auer jan-auer marked this pull request as ready for review September 5, 2019 22:14
@jan-auer jan-auer requested review from willglynn and removed request for willglynn September 5, 2019 22:14
willglynn
willglynn approved these changes Sep 6, 2019
View reviewed changes
Copy link
Collaborator

@willglynn willglynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

src/dbi.rs Show resolved Hide resolved
@jan-auer jan-auer merged commit 802bd94 into getsentry:master Sep 6, 2019
@jan-auer jan-auer deleted the feat/missing-docs branch September 6, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willglynn willglynn willglynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-auer @willglynn