Skip to content

Commit

Permalink
Remove minLevel from logback documentation.
Browse files Browse the repository at this point in the history
This behavior is supported by logback itself with [Filters][f] -- we
shouldn't need to implement it independently. I'm a little confused why
this was implemented in the first place, when it seems like this can be
implemented on a per-appender basis using a [ThresholdFilter][tf].

Fixes GH-157.

[f]: http://logback.qos.ch/manual/filters.html
[tf]: http://logback.qos.ch/manual/filters.html#thresholdFilter
  • Loading branch information
tkaemming committed Dec 16, 2015
1 parent 9331d4b commit f5ad3dc
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions raven-logback/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ In the `logback.xml` file set:
<!--<ravenFactory>net.kencochrane.raven.DefaultRavenFactory</ravenFactory>-->
<!-- Optional, allows setting app release information -->
<!-- <release>1.0.0</release>
<!-- Optional, events with level bellow minLevel won't be sent, defaults to WARN -->
<!-- <minLevel>ERROR</minLevel>
</appender>
<root level="warn">
<appender-ref ref="Sentry"/>
Expand Down

0 comments on commit f5ad3dc

Please sign in to comment.