Conversation
@@ -18,8 +18,7 @@ | |||
"raven": "./bin/raven" | |||
}, | |||
"scripts": { | |||
"pretest": "npm install", | |||
"test": "NODE_ENV=test mocha --reporter dot && NODE_ENV=test coffee ./test/run.coffee" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing the coffee test run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattrobenolt it's a duplicate test run. There's no reason to run the tests twice. I can revert that change though since it's not relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted that change as it was a bikeshed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't exactly a duplicate run becuase coffeescript modifies the stack traces and injects stuff in. So we run the entire test suite with the coffee script runner as well to make sure that's ok. :)
I noticed I forgot to fix some tests after rebasing on master, those are fixed now. |
@mattrobenolt I removed the node 0.6 from travis for you :) |
That was a surprising pain in the ass to pull in :) |
ref b725bd5 |
The default recommended rate limiting on the sentry
documentation rate limits by
projectId
.It's a better default to talk to a sentry server using the
/api/{projectId}/store
API.This way multiple services talking to the same sentry
server will not all get rate limited under the same
projectId (which is presumably the empty string).