This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Update Node flags for v8.X instrumentation tests #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
node-8-instrumentation
branch
from
60f7236
to
a68fee8
Compare
Added flags: --expose-internals --expose-http2 Included one edge case, where we have to remove http2 flag.
kamilogorek
force-pushed
the
node-8-instrumentation
branch
from
a68fee8
to
95ae44c
Compare
|
Awesome. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--expose-internalsflag to all tests and--expose-http2for Node >= 8 only, as it's not supported in previous versions.Included one edge case, where we have to remove http2 flag, as the test itself is asserting it's absence.