This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 134
WIP: Add support for sending event requests via proxy #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usage / test script:
http in URL -> HTTPProxyTransport |
mfpierre
reviewed
Sep 19, 2017
lib/transports.js
Outdated
@@ -25,6 +27,17 @@ HTTPTransport.prototype.send = function(client, message, headers, eventId, cb) { | |||
port: client.dsn.port || this.defaultPort, | |||
ca: client.ca | |||
}; | |||
|
|||
// set path apprpriately when using proxy | |||
if (this.options.hasOwnProperty('host')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndmanvar I think you're missing setting the Host
header to be set to client.dsn.host
in case of proxy.
Without it the host header would keep the proxy host which cause the HTTP request to be rejected by the sentry.io server
https://gist.github.com/ndmanvar/7ae7b4db7bf1cda30545c1480fde77fe Works with https.
|
Gist is the current workaround. |
6c5c58b
to
bf9dbab
Compare
Closed this, as I am working off of new branch: #397 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge...just yet.