This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
fix: shallow-clone context instead of deep-copy #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
commented
Apr 24, 2018
| @@ -333,8 +333,7 @@ extend(Raven.prototype, { | |||
| cb = kwargs; | |||
| kwargs = {}; | |||
| } else { | |||
| // Do not use reference, as we'll modify this object later on | |||
| kwargs = kwargs ? JSON.parse(stringify(kwargs)) : {}; | |||
| kwargs = utils.isPlainObject(kwargs) ? extend({}, kwargs) : {}; | |||
There was a problem hiding this comment.
extend({}, 'something') will treat each letter as a key so we want to avoid it
kamilogorek
commented
Apr 24, 2018
| @@ -359,7 +340,7 @@ describe('raven.Client', function() { | |||
| foo: null | |||
| } | |||
| }; | |||
| kwargs.extra.foo = kwargs; | |||
| kwargs.extra.foo = kwargs.extra; | |||
There was a problem hiding this comment.
It had to be changed, as referencing kwargs directly wouldn't work in this test, as it's not the same reference anymore.
mitsuhiko
approved these changes
Apr 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451
I'm not sure if this should be
2.5.1or2.6.0though. Thoughts?