Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Ignoring exceptions on Flask does not work anymore with child exceptions #963

Closed
noirbizarre opened this issue Feb 17, 2017 · 4 comments · Fixed by #964
Closed

Ignoring exceptions on Flask does not work anymore with child exceptions #963

noirbizarre opened this issue Feb 17, 2017 · 4 comments · Fixed by #964

Comments

@noirbizarre
Copy link
Contributor

#821 is a fundamental behavior change on change on exception handling which is not documented into the changelog.
The main consequence is that child exception are now reported to sentry unless you list all child exceptions.
On a big project, this is really painful and this ends with a sentry massive polution with unwanted expection.

On flask, as handled HTTP errors are exception-based, I have to switch from ignoring HTTPException to ignoring every child, the werkzeug ones and the app children ones. In a case where the app can also host plugins raising custom exception, it becomes a nightmare.

@dcramer
Copy link
Member

dcramer commented Feb 17, 2017

@noirbizarre you simply mean in that it is doing string vs class matching now?

@noirbizarre
Copy link
Contributor Author

Yes, isinstance() has been replaced by string matching.
I'm beginning a PR to support both, any objection before I start ?

@dcramer
Copy link
Member

dcramer commented Feb 17, 2017

@noirbizarre not opposed at all -- that was going to be my suggestion

@noirbizarre
Copy link
Contributor Author

Great ! 👍

dcramer added a commit that referenced this issue Mar 6, 2017
…ritance

Handle ignore_exceptions values being class or string
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants