This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Modify http data string sanitizing to account for cookie delimiter #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarbuto
force-pushed
the
sanitize_http_cookies
branch
3 times, most recently
from
499181f
to
1e2ea5c
Compare
jbarbuto
force-pushed
the
sanitize_http_cookies
branch
from
1e2ea5c
to
8a12fa1
Compare
|
A closer look at the code showed cookies can be either a dict or string, so the tests now handle both. |
|
Great ! I need to dig a bit this part of raven but looks rather good at first sight. |
|
👍 |
|
@jbarbuto grats for the work and thanks a lot. Sorry it took me so long to review. |
xordoquy
added a commit
that referenced
this pull request
Feb 11, 2015
Modify http data string sanitizing to account for cookie delimiter
|
Changes Unknown when pulling 8a12fa1 on jbarbuto:sanitize_http_cookies into * on getsentry:master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sanitizing http data strings, a
&was treated as the only possible delimiter, while cookies use;instead. This accounts for the cookie delimiter as well.This assumes that a string is the proper type for cookie data in the http interface, as sent by the tornado client in https://github.com/getsentry/raven-python/blob/5.1.1/raven/contrib/tornado/__init__.py#L191 and shown in http://sentry.readthedocs.org/en/latest/developer/interfaces/#sentry.interfaces.http.Http. The previous tests indicate it's a dict instead.