Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does faraday version requirement needs to be ~> 0.8? #6

Closed
hellvinz opened this issue May 9, 2012 · 2 comments
Closed

does faraday version requirement needs to be ~> 0.8? #6

hellvinz opened this issue May 9, 2012 · 2 comments

Comments

@hellvinz
Copy link
Contributor

hellvinz commented May 9, 2012

the sentry-raven.gemspec is asking faraday 0.8.0 rc2

 gem.add_dependency "faraday", "~> 0.8.0.rc2"

While reading the faraday's changelog the 0.8 version seems to only impact get, head, delete https://github.com/technoweenie/faraday/wiki/Changelog.

Can the requirements to faraday be >=0.7.6? Lots of projects have not stepped to 0.8. This could avoid conflicts in Gemfile. raven-ruby doesn't need the 0.8 version (I've ran the raven-ruby tests in 0.7.6 and they all passe)

regards

@coderanger
Copy link
Contributor

Test coverage is almost nothing right now, so that isn't a good indicator. 0.8 added the new syntax for middleware stuffs. It could probably be reverted to the old one, patches welcome.

@nateberkopec
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants