Skip to content

Commit

Permalink
feat(spans): Allow resource.img spans (#2855)
Browse files Browse the repository at this point in the history
#2826 introduced grouping
`resource.img` spans by domain + extension, allowing us to enable span
metrics for this op. Now also enable `resource.img` for the spans
dataset.
  • Loading branch information
jjbayer committed Dec 18, 2023
1 parent bfa6be2 commit 73bd185
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
- Allow ingestion of metrics summary on spans. ([#2823](https://github.com/getsentry/relay/pull/2823))
- Add metric_bucket data category. ([#2824](https://github.com/getsentry/relay/pull/2824))
- Org rate limit metrics per bucket. ([#2836](https://github.com/getsentry/relay/pull/2836))
- Keep only domain and extension for image resource span grouping. ([#2826](https://github.com/getsentry/relay/pull/2826))
- Emit image resource spans, grouped by domain and extension. ([#2826](https://github.com/getsentry/relay/pull/2826), [#2855](https://github.com/getsentry/relay/pull/2855))
- Parse timestamps from strings in span OpenTelemetry schema. ([#2857](https://github.com/getsentry/relay/pull/2857))

## 23.11.2
Expand Down
5 changes: 3 additions & 2 deletions relay-server/src/actors/processor/span/processing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -314,16 +314,17 @@ fn is_allowed(span: &Span) -> bool {
.unwrap_or_default();
op.contains("resource.script")
|| op.contains("resource.css")
|| op == "resource.img"
|| op == "http.client"
|| op.starts_with("app.")
|| op.starts_with("ui.load")
|| op.starts_with("file")
|| op.starts_with("db")
|| (op.starts_with("db")
&& !(op.contains("clickhouse")
|| op.contains("mongodb")
|| op.contains("redis")
|| op.contains("compiler"))
&& !(op == "db.sql.query" && (description.contains("\"$") || system == "mongodb"))
&& !(op == "db.sql.query" && (description.contains("\"$") || system == "mongodb")))
}

/// We do not extract or ingest spans with missing fields if those fields are required on the Kafka topic.
Expand Down

0 comments on commit 73bd185

Please sign in to comment.