New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub more IP addresses #1693

Closed

jjbayer opened this issue Dec 13, 2022 · 0 comments

Assignees

Member

jjbayer commented Dec 13, 2022

If the flag scrub_ip_addresses is enabled in legacy data scrubbing, we only scrub a handful of fields:

relay/relay-general/src/pii/convert.rs

Lines 41 to 43 in f884122

    
           if datascrubbing_config.scrub_ip_addresses { 
        
               applications.insert(KNOWN_IP_FIELDS.clone(), vec!["@anything:remove".to_owned()]); 
        
           }

Should we instead (or in addition) apply the rule @ip:replace when this flag is enabled, such that any IP is caught?

relay/relay-general/src/pii/builtin.rs

Lines 89 to 94 in f884122

    
           "@ip:replace" => RuleSpec { 
        
               ty: RuleType::Ip, 
        
               redaction: Redaction::Replace(ReplaceRedaction { 
        
                   text: "[ip]".into(), 
        
               }), 
        
           };

See also getsentry/sentry-docs#5916.

The text was updated successfully, but these errors were encountered:

TBS1996 self-assigned this

TBS1996 mentioned this issue

feat(general): Scrub all fields with IP address #1725

Merged

TBS1996 added a commit that referenced this issue


          feat(general): Scrub all fields with IP address (#1725)

156c2ae

This change will scrub all fields containing an IP address, rather than
only scrubbing certain fields known to have them

referencing issue #1693

Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

jan-auer closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment