Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make global config required for processing #2584

Closed
jjbayer opened this issue Oct 10, 2023 · 1 comment · Fixed by #2697
Closed

Make global config required for processing #2584

jjbayer opened this issue Oct 10, 2023 · 1 comment · Fixed by #2697
Assignees

Comments

@jjbayer
Copy link
Member

jjbayer commented Oct 10, 2023

Before a global config is loaded / if a global config cannot be loaded during an incident, we currently fall back to using a default global config everywhere.

There are several use cases where if we actually want to rely on dynamic configuration, we have to be able to load it, e.g.

  • When we move span metrics extraction config to sentry,
  • when we move config for generic inbound filters to sentry.

Solution

Just like envelopes get buffered until a valid project state is available, we should queue envelopes until a valid global config is available.

@TBS1996
Copy link
Contributor

TBS1996 commented Dec 11, 2023

finished with #2765

@TBS1996 TBS1996 closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants