ref(server): Remove noisy payload parsing errors #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes errors when event payloads or session payloads cannot be parsed. These
were reported as "failed to extract event" and "failed to store session",
respectively.
Such errors are completely expected when invalid payloads are sent into Relay.
They were originally introduced to debug broken SDKs, but in the way they are
being reported they are neither actionable to the Relay development team, nor
anyone running Relay onpremise.
Eventually, we will bring this back in form of a metric including the SDK
version, and potentially a mechanism to sample invalid payloads. For now, these
errors are not actionable, and drown real issues in Sentry.