Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-reports): Protocol support for client reports #1081

Merged
merged 7 commits into from
Sep 10, 2021

Commits on Sep 9, 2021

  1. feat(client-reports): Protocol support for client reports

    This adds support for client reports from the SDKs. This feature is primarily
    used to allow client SDKs to emit outcomes.
    
    The way this is currently implemented is that we add a new envelope item
    type called client_report which contains these outcomes. The envelope item
    type is intentionally kept flexible for future expansion as we already discussed
    emitting other internal debug information upstream which is unrelated to
    outcomes (eg: number of breadcrumbs discarded and configuration errors).
    
    Because of how SDKs are currently implemented we now reserve internal
    as data category for such metric items. Relay however will never emit
    such a data category as we do not want to communicate actual rate limits
    for such envelope items.
    
    From the relay perspective any outcome reason that an SDK emits is
    acceptable and upstreamed. It's up to the snuba consumer to whitelist
    these outcomes to avoid writing bad data into the kafka topic. This
    way SDKs can send more outcomes even if relays have not been updated.
    untitaker authored and mitsuhiko committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    0140105 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f33f9b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fabd334 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c731653 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    50d34d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. fix: lint

    mitsuhiko committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ca07a79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15adade View commit details
    Browse the repository at this point in the history