feat(metrics): Extract measurement ratings, port from frontend [INGEST-542] #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to tag those in metrics because we probably don't have sufficient querying capabilities to query for thresholds/histograms from metric distributions. "rating" is a made-up term, I couldn't find prior art for a term that describes "the thing coming from thresholds". Extracted from: https://github.com/getsentry/sentry/blob/bff64dcf2722dec969d0b9e82366855382238930/static/app/views/performance/landing/widgets/widgetDefinitions.tsx#L94-L133
jjbayer
reviewed
Nov 17, 2021
relay-server/src/actors/envelopes.rs
Outdated
| "measurement.fcp" => rate_range(1000.0, 3000.0), | ||
| "measurement.fid" => rate_range(100.0, 300.0), | ||
| "measurement.cls" => rate_range(0.1, 0.25), | ||
| _ => "unknown".to_owned(), |
There was a problem hiding this comment.
Should we return None here instead, and only insert the tag if Some?
There was a problem hiding this comment.
i prefer this because then you know for which buckets this classification ran at all
nvm that's not very useful, I'll remove
jjbayer
approved these changes
Nov 17, 2021
jan-auer
added a commit
that referenced
this pull request
Nov 24, 2021
* master: test(outcomes): Fix sort order in flaky test (#1135) feat(outcomes): Aggregate more outcomes (#1134) ref(outcomes): Fold processing vs non-processing into single actor (#1133) build: Update symbolic to support UE5 (#1132) feat(metrics): Extract measurement ratings, port from frontend (#1130) feat(metrics): Another statsd metric to measure bucket duplication (#1128) feat(outcomes): Emit outcomes as client reports (#1119) fix: Move changelog line to right version (#1129) fix(dangerjs): Do not suggest to add JIRA ticket to changelog (#1125) feat(metrics): Tag metrics by transaction name [INGEST-542] (#1126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to tag those in metrics because we probably don't have
sufficient querying capabilities to query for thresholds/histograms from
metric distributions.
"rating" is a made-up term, I couldn't find prior art for a term that
describes "the thing coming from thresholds".
Extracted from: https://github.com/getsentry/sentry/blob/bff64dcf2722dec969d0b9e82366855382238930/static/app/views/performance/landing/widgets/widgetDefinitions.tsx#L94-L133