feat(metrics): Extract transaction user [INGEST-804] [INGEST-544] #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
reviewed
Jan 11, 2022
| assert_eq!(metrics[1].tags["measurement_rating"], "meh"); | ||
|
|
||
| for metric in metrics { | ||
| for metric in &metrics[0..6] { | ||
| assert!(matches!(metric.value, MetricValue::Distribution(_))); |
There was a problem hiding this comment.
i would keep all the tag-assertions for all metrics except for this one
untitaker
approved these changes
Jan 11, 2022
jjbayer
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 12, 2022
Add metric extracted in getsentry/relay#1164 to the metric allowlist.
GitHub deprecated the git protocol for cloning repos recently: https://github.blog/2021-09-01-improving-git-protocol-security-github/
…t-transaction-user
…t-transaction-user
…t-transaction-user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
user.idas unique transaction user.