feat(profiling): Add support for Rust profiles ingestion #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Jun 8, 2022
jjbayer
approved these changes
Jun 9, 2022
jan-auer
approved these changes
Jun 9, 2022
relay-server/src/utils/profile.rs
Outdated
| pub struct RustSample { | ||
| pub frames: Vec<RustFrame>, | ||
| pub thread_name: String, | ||
| pub thread_id: u64, |
There was a problem hiding this comment.
The thread_id can be alphanumeric on some platforms, at least we also support strings in the event protocol. Are you certain you can constrain this to u64? See ThreadId. You could import and use this enum directly here.
phacops
reviewed
Jun 9, 2022
Rust as_nanos returns u128. Unfortunately we can't store u128 into the DB, nor can Golang handle u128. As a fix here some fields are refactored to hold u64 values. That's enough to store the timing info we need without causing an overflow.
… and rust for debug images
viglia
force-pushed
the
viglia/profiling-add-rust-support
branch
from
8db77e2
to
977502c
Compare
phacops
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at supporting the ingestion of Rust profiles.
This was tested e2e by sending and ingesting a sample rust profile.
Link to related
sentryPR