feat(profiling): Add thread metadata to tell which thread is the main #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Cocoa profiles
jan-auer
approved these changes
Jun 27, 2022
jan-auer
added a commit
that referenced
this pull request
Jun 30, 2022
* master: fix(profiling): Increase profile maximum size by an order of magnitude (#1321) feat(dynamic-sampling): Extend protocol [INGEST-1395 INGEST-1397] (#1318) ref(dynamic-sampling): Sample trace after metrics extraction (#1317) ref(project_redis): Add counter for redis cache usage (#1322) feat(profiling): Add thread metadata to tell which thread is the main (#1320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to identify which thread is the main thread in Cocoa profiles. The client will now set a boolean in thread metadata to indicate the main thread. Here is the related change in the SDK getsentry/sentry-cocoa#1918.
This should be an optional field.