Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): More SDK-based logic for transaction name extraction [INGEST-1524] #1356

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Jul 28, 2022

Adds more cases of SDK / tag combinations that should be treated as
high-cardinality transaction names. This was obtained from tests with
real-world data, indicating SDK bugs falling back to raw URLs:

  • sentry.python: integrations contains "django" when http.status is
    404
  • sentry.javascript.node: integrations contains "Express" when
    http.method is "OPTIONS"
  • sentry.javascript.nextjs: all
  • sentry.php.laravel: all
  • sentry.php.symphony: all

More info on how we found problematic SDK cases can be found in the
Jira ticket. The
SDK bugs were filed separately.

Also in this PR: Add a statsd metric for the extracted transaction name.

@jan-auer jan-auer marked this pull request as ready for review July 28, 2022 19:10
@jan-auer jan-auer requested a review from a team July 28, 2022 19:10
@jan-auer jan-auer merged commit 956daa6 into feat/default-transaction-source Jul 28, 2022
@jan-auer jan-auer deleted the feat/high-cardinality-sdks branch July 28, 2022 19:22
@jan-auer jan-auer restored the feat/high-cardinality-sdks branch July 28, 2022 19:28
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.
Instructions and example for changelog

For changes exposed to the Python package, please add an entry to py/CHANGELOG.md. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.

For changes to the Relay server, please add an entry to CHANGELOG.md under the following heading:

  1. Features: For new user-visible functionality.
  2. Bug Fixes: For user-visible bug fixes.
  3. Internal: For features and bug fixes in internal operation, especially processing mode.

To the changelog entry, please add a link to this PR (consider a more descriptive message):

- More SDK-based logic for transaction name extraction. ([#1356](https://github.com/getsentry/relay/pull/1356))

If none of the above apply, you can opt out by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against efe0382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants