build(futures): Swap package names for futures 0.1 and 0.3 #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a bit tricky to review since it includes the changes from your other PR. The way to do this in github is to select the branch of your other PR as "base", you can click "edit" to the right of the PR title to do this. That way only the changes from this PR will show up in the diff. Once your other PR is merged to master github will automatically switch the base of this PR back to "master" and you can safely merge this PR. |
tobias-wilfert
changed the base branch from
master
to
tobias-wilfert/future-proofing-relay
tobias-wilfert
force-pushed
the
tobias-wilfert/refactor-futures
branch
from
c8ef372
to
cffe263
Compare
jan-auer
changed the title
jan-auer
approved these changes
Aug 1, 2022
sl0thentr0py
approved these changes
Aug 1, 2022
jan-auer
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to future-proof Relay as outlined here #1374 the goal is to use the standard Futures instead of the older version of the crate. With this effort currently under way this PR refactors the system by changing
futurestofutures01andfutures03tofutures. As such it builds further on the changes made here #1374.#skip-changelog