fix(log): Honor SentryConfig.enabled and don't init SDK at all if it is false
#1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
changed the title
SentryConfig.enabled and don't init SDK at all if it is false.
sl0thentr0py
changed the title
SentryConfig.enabled and don't init SDK at all if it is false.SentryConfig.enabled and don't init SDK at all if it is false
sl0thentr0py
force-pushed
the
neel/disable-reporting
branch
2 times, most recently
from
fcabb2f
to
382a528
Compare
Fixes edge case behaviour where `enabled` is false but SENTRY_DSN is present on the machine and the SDK internally still picks it up. This came up because relay in an AWS extension setting was reporting errors to the user's project and eating up their quota.
sl0thentr0py
force-pushed
the
neel/disable-reporting
branch
from
382a528
to
bca7943
Compare
untitaker
approved these changes
Aug 4, 2022
Swatinem
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes edge case behavior where
enabledis false butSENTRY_DSNis present on the machine and the SDK internally still picks it up.This came up because relay in an AWS extension setting was reporting errors to the user's project and eating up their quota.
Note that in our AWS layer, we do have
SENTRY_DSNset in the env to also be used by the language specific SDKs (node/python).Local testing
I tested that stuff like
relay_log::capture_errorno-ops successfully and does not break stuff even when the SDK is not initialized. And the fact that stuff compiles.References
Zendesk ticket