feat(profiling): Distinguish various discard reasons for profiles #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiles can be discarded for various reasons. Right now, all discarded profiles produce an outcome with the same reason. This makes it difficult to track down why a profile was discarded. This change breaks the invalid outcome into 3 separate reasons to help understand the behaviour better. - `DiscardReason::ProcessProfile` - there are syntactic problems with the profile and cannot be parsed - `DiscardReason::InvalidProfile` - there are semantic problems with the profile and should not be ingested - `DiscardReason::Internal` - something else is going on, and we should look into it
jan-auer
approved these changes
Aug 8, 2022
relay-server/src/actors/processor.rs
Outdated
| @@ -370,6 +370,15 @@ fn outcome_from_parts(field: ClientReportField, reason: &str) -> Result<Outcome, | |||
| } | |||
| } | |||
|
|
|||
| pub fn outcome_from_profile_error(err: relay_profiling::ProfileError) -> Outcome { | |||
There was a problem hiding this comment.
nit: This function looks like an implementation detail that doesn't have to be part of the public interface.
Suggested change
| pub fn outcome_from_profile_error(err: relay_profiling::ProfileError) -> Outcome { | |
| fn outcome_from_profile_error(err: relay_profiling::ProfileError) -> Outcome { |
viglia
approved these changes
Aug 9, 2022
…istinguish-various-discard-reasons-for-profiles
Zylphrex
deleted the
txiao/feat/distinguish-various-discard-reasons-for-profiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiles can be discarded for various reasons. Right now, all discarded profiles
produce an outcome with the same reason. This makes it difficult to track down
why a profile was discarded. This change breaks the invalid outcome into 3
separate reasons to help understand the behaviour better.
DiscardReason::ProcessProfileDiscardReason::InvalidProfileDiscardReason::Internal