ref(server): Remove overall envelope handling timeout #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Aug 9, 2022
flub
approved these changes
Aug 9, 2022
| if let Some(outcome) = outcome { | ||
| envelope_context.borrow().send_outcomes(outcome); | ||
| } | ||
| } |
There was a problem hiding this comment.
it's kind of sad to be able to use the power of exhaustive matching here. but that's not this PRs fault so just an aside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the overall timeout for Envelope buffering and handling,
controlled by the
cache.envelope_expiryoption. There is a range oftimeouts for project configs and upstream requests that individually
control these processes. The overall buffer is controlled by
cache.envelope_buffer_size.A reasonable overall time limit is hard to set. In many cases, either
the limit is too short to bridge real downtimes, or it's too long for
the buffer size. In practice, we've been relying on the count-based
limit exclusively. With proper disk-based caching, the limit could be
set to a product-limit such as 30 days.
The option remains in the config and is now marked as unused. It is
likely that some form of time-based expiry is re-introduced once
disk-based caching is implemented.