fix(normalization): Light normalize stacktrace before filtering [ISSUE-1574] #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browser extension filters require the normalization of the last frame of the stacktrace of the first exception of the event. Currently, this isn't part of the light normalization, which makes the filter useless and events coming from browser extensions get to Sentry.
relay-general/src/store/normalize.rs
Outdated
Comment on lines
586
to
587
| normalize_exceptions(event)?; // Browser extension filters look at the stacktrace | ||
| light_normalize_stacktraces(event)?; |
There was a problem hiding this comment.
light_normalize_stacktraces doesn't replace normalize_exceptions, as it works with stacktraces. The operation is simple and it's possible to refactor the method and keep only the stuff we need in light normalization, but I don't want to refactor that until it becomes an issue or we need some performance improvement.
jjbayer
reviewed
Aug 18, 2022
We don't really need the other param as it always has the same value as the first one.
jjbayer
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser extension filters require the normalization of the last frame of
the stacktrace of the first exception of the event.
Currently, this isn't part of the light normalization, which makes the
filter useless and events originating in browser extensions get to Sentry.