Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profiling): Fix logic reversal typo #1463

Merged
merged 2 commits into from
Sep 12, 2022
Merged

feat(profiling): Fix logic reversal typo #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a34ed09
feat(profiling): Fix logic reversal typo
phacops Sep 12, 2022
78127fc
Add a changelog entry
phacops Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- Add InvalidReplayEvent outcome. ([#1455](https://github.com/getsentry/relay/pull/1455))
- Add replay and replay-recording rate limiter. ([#1456](https://github.com/getsentry/relay/pull/1456))
- Support profiles tagged for many transactions. ([#1444](https://github.com/getsentry/relay/pull/1444))
- Fix logic reversal typo related to profiling. ([#1463](https://github.com/getsentry/relay/pull/1463))

**Features**:

Expand Down
3 changes: 2 additions & 1 deletion relay-server/src/actors/processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ impl EnvelopeProcessor {
let context = &state.envelope_context;

if let Some(item) = envelope.take_item_by(|item| item.ty() == &ItemType::Profile) {
if profiling_enabled {
if !profiling_enabled {
return;
}

Expand All @@ -872,6 +872,7 @@ impl EnvelopeProcessor {
}
}
Err(err) => {
println!("{:#?}", err);
context.track_outcome(
outcome_from_profile_error(err),
DataCategory::Profile,
Expand Down