ref: Remove unused rate_limits from ProcessEnvelopeState #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rate limits are not used anywhere and it is confusing that they are passed around. It is easier to understand who uses the EnvelopeLimiter's emitted rate limits if we remove this unused data.
jan-auer
approved these changes
Oct 6, 2022
jan-auer
added a commit
that referenced
this pull request
Oct 7, 2022
* master: ref: Remove unused rate_limits from ProcessEnvelopeState (#1516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rate limits are not used anywhere and it is confusing that they
are passed around. It is easier to understand who uses the
EnvelopeLimiter's emitted rate limits if we remove this unused data.