fix(server): Report indexing outcomes for dynamic sampling [INGEST-1681] #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
commented
Nov 2, 2022
jan-auer
changed the title
olksdr
reviewed
Nov 2, 2022
olksdr
approved these changes
Nov 2, 2022
mitsuhiko
reviewed
Nov 2, 2022
jjbayer
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves outcomes for transactions dropped through dynamic sampling to the
transaction_indexeddata category. This ensures that within each datacategory, every transaction is counted exactly once and totals sum up.
Example: Send 100 transactions to Sentry at a 50% sample rate. For 100
transactions, Relay extracts metrics and we report a
transaction:acceptedoutcome. For 50 transactions we report
transaction_indexed:filteredand for 50we report
transaction_indexed:accepted.