feat(config): Add a configuration for the keepalive_timeout #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Nov 29, 2022
|
@jan-auer The code has been modified, can you take a look at it? |
jan-auer
approved these changes
Nov 30, 2022
|
@iker-barriocanal A changelog has been added |
Co-authored-by: Jan Michael Auer <account@jauer.org>
|
@jan-auer Did a ci mission fail? |
auto-merge was automatically disabled
December 9, 2022 03:43
Head branch was pushed to by a user without write access
klboke
requested review from
jan-auer and
iker-barriocanal
and removed request for
jan-auer and
iker-barriocanal
olksdr
approved these changes
Dec 19, 2022
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| - Add OpenTelemetry Context. ([#1617](https://github.com/getsentry/relay/pull/1617)) | |||
| - Add `app.in_foreground` and `thread.main` flag to protocol. ([#1578](https://github.com/getsentry/relay/pull/1578)) | |||
| - Add support for View Hierarchy attachment_type. ([#1642](https://github.com/getsentry/relay/pull/1642)) | |||
| - Add support for `keepalive_timeout` configuration. ([#1645](https://github.com/getsentry/relay/pull/1645)) | |||
There was a problem hiding this comment.
Could you, please, move this CHANGELOG entry to Features in Unreleased section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open the keepalive_timeout configuration of relay server, when the IdleConnTimeout of the client is smaller than the keepalive_timeout of the server, the server will actively disconnect, then the client will report some unnecessary errors, expect to open the keepalive_timeout configuration to solve these problems