fix: Do not skip null values in pairlists #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
previously approved these changes
Jan 23, 2019
mitsuhiko
previously approved these changes
Jan 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 63.65% 63.73% +0.07%
==========================================
Files 82 82
Lines 8749 8768 +19
==========================================
+ Hits 5569 5588 +19
Misses 3180 3180
Continue to review full report at Codecov.
|
mitsuhiko
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuples and tuple structs are a kind of array, but we never excluded them from the "structs always default to skip_serialization=null" rule we established in our custom derive.