New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codeowners): Find codeowner path matches with rust #1746
Conversation
dce6759
to
40b4d29
Compare
@NisanthanNanthakumar I did not look at your benchmark in detail, but in my experience running a benchmark with a global LRU cache can easily skew results, because you get much better cache locality in the experiment than in production. Have you considered using pre-compiled regexes on the Python side instead? |
@jjbayer yea I realized that too. Thats why the plan is to push to production under a feature flag and run it against a sampled subset of the WRT the pre-compiled regexes in Python suggestion, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for walking me through it!
40b4d29
to
08b55e0
Compare
55389ea
to
bc80554
Compare
fix changelog new line dash
2f8e648
to
c2d3c04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check the pattern translation logic in detail, but the rest looks good to me!
We will have to release a new version of the Python library if you want to run this in production.
Proof of Concept PR
Benchmarked this solution agains the baseline python implementation getsentry/sentry#43294
This code is benchmarking ~3 times faster than the baseline python implementation. So it is ready to be merged into Sentry.