Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replays): Enforce rate limits #1877

Merged
merged 5 commits into from
Feb 24, 2023
Merged

fix(replays): Enforce rate limits #1877

merged 5 commits into from
Feb 24, 2023

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Feb 23, 2023

Rate limits for replays were checked but not enforced. See test case.

@jjbayer jjbayer requested review from jan-auer, cmanallen and a team February 23, 2023 16:13
olksdr
olksdr reviewed Feb 23, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
relay-server/src/utils/rate_limits.rs Outdated Show resolved Hide resolved
jjbayer and others added 2 commits February 23, 2023 17:54
@jjbayer @olksdr
Update CHANGELOG.md
5898325 
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
@jjbayer @olksdr
Update relay-server/src/utils/rate_limits.rs
494c470 
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
@jan-auer
Copy link
Member

Moving ahead with this as the monthly quota is not counted through these rate limits. We need to follow up with correct counting, however.

@jan-auer jan-auer merged commit d66c8c5 into master Feb 24, 2023
@jan-auer jan-auer deleted the fix/replay-rate-limit-enforcement branch February 24, 2023 09:51
jan-auer added a commit that referenced this pull request Feb 24, 2023
@jan-auer
Merge branch 'master' into ref/startup
e4cf392 
* master:
  build: Upgrade sentry SDK to 0.30.0 (#1883)
  chore(metrics): Remove satisfaction thresholds (#1881)
  feat(profiling): Add javascript platform (#1876)
  fix(replays): Enforce rate limits (#1877)
@jjbayer jjbayer mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr left review comments

@jan-auer jan-auer jan-auer approved these changes

@cmanallen cmanallen Awaiting requested review from cmanallen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjbayer @jan-auer @olksdr