feat(txnames): Use txNameReady flag #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iker-barriocanal
approved these changes
May 22, 2023
jjbayer
added a commit
that referenced
this pull request
Jun 13, 2023
In #2139, we transitioned to marking all URL transactions as "sanitized" once sentry provides the "ready" flag. However, this results in a bad onboarding experience for new projects because they still see `<< unparameterized >>` for the first ~10 hours. This PR removes the "ready" condition, such that _all_ transactions with source URL will now get their transaction name added as a metric tag. Since we were already doing this for all but the newest projects, this should not add much cardinality after all. But we have to keep an eye on the cardinality limiter in the first few hours / days after deploying this. Fixes #2186 --------- Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start using the flag introduced by getsentry/sentry#48993 and #2128.
Once the clusterer has run ~10 times, trust that all the rules than can be discovered have been discovered, and mark all incoming URL transactions as sanitized.
ref: https://github.com/getsentry/team-ingest/issues/124