Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove profiling feature flag #2146

Merged
merged 2 commits into from
May 23, 2023
Merged

fix: Remove profiling feature flag #2146

merged 2 commits into from
May 23, 2023

Conversation

cleptric
Copy link
Member

We forgot to remove this feature flag when profiling was GAed.

Closes #2132

@cleptric cleptric added the bug Something isn't working label May 22, 2023
@cleptric cleptric requested a review from phacops May 22, 2023 17:01
@cleptric cleptric self-assigned this May 22, 2023
@cleptric cleptric requested a review from a team May 22, 2023 17:01
@phacops
Copy link
Contributor

phacops commented May 22, 2023

This is important when running Relay as a proxy, since there's no project config, it filters all profiles at the proxy level. Since profiling is now GA, this can be safely removed.

@cleptric cleptric merged commit 50ea5a6 into master May 23, 2023
17 checks passed
@cleptric cleptric deleted the remove-profiling-flag branch May 23, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiles not recording when using Relay in proxy or static modes
3 participants