fix(filter): Added is_enabled field to transactions name filter #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Jun 26, 2023
| @@ -141,12 +141,14 @@ pub struct ErrorMessagesFilterConfig { | |||
| pub struct IgnoreTransactionsFilterConfig { | |||
| /// List of patterns for ignored transactions that should be filtered. | |||
| pub patterns: GlobPatterns, | |||
| /// True if the filter is enabled | |||
| pub is_enabled: bool, | |||
There was a problem hiding this comment.
There is a tiny chance that somebody updated their external Relay since this filter was introduced. These old Relays would ignore this flag until they update again. But given the short time frame and the fact that there was no calendar release in between, I think we can ignore this problem.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
iker-barriocanal
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the is_enabled field to the TransactionsName configuration.
The flag is added in order to make it easier to work with it in Sentry (since all inbound filters have it).