fix(metrics): Move TrimmingProcessor to light normalization
#2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
TrimmingProcessor to light normalization
olksdr
approved these changes
Jul 25, 2023
Yep I would like to revert the split between light normalization and store normalization eventually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
TrimmingProcessoris not part of light normalization, we extract the untrimmed transaction name from the payload, which then gets dropped by the aggregator.Solution: Call
TrimmingProcessorinlight_normalize_event.After deploying this, we have to keep an eye on the
event.processing_timemetric.Fixes https://github.com/getsentry/team-ingest/issues/187