feat(spans): Update db table extraction to add comma separators #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we work on adding support for keys with multiple values in metric tags, in the short term we want to unblock work in the database module. To do this, we're going to perform a wildcard search on the metric value in the backend on a comma seperated list. The `span.domain` is currently emitted as a comma seperated list when there are multiple table values, but no commas are added if there single table values. This patch updates that to always add commas. For example what was the `users` table would become `,users,`. This is important because the wildcard search going to be added is going to do something similar to `*,table_name,*`. We don't want to confuse between two tables like `org` and `org_users`, which can happen when we don't have the wildcard. This is a hack, but given we are changing this anyway when we get multiple I think it's fine to add as it's needed to unblock the db module GA.
wmak
approved these changes
Sep 19, 2023
jan-auer
approved these changes
Sep 20, 2023
jan-auer
added a commit
that referenced
this pull request
Sep 22, 2023
* master: fix(spans): Handle ActiveRecord official and custom spelling (#2525) feat(spans): Update db table extraction to add comma separators (#2521) fix(profiling): Remove profile ID from transaction context if no profile is found in the envelope (#2523) feat(spans): Ignore more spans for the DB module (#2522) release: 23.9.1 release: 23.9.0 fix(spans): Add a description to the segment as well (#2512) fix(spans): Filter DB spans for MongDB queries (#2520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we work on adding support for keys with multiple values in metric tags, in the short term we want to unblock work in the database module. To do this, we're going to perform a wildcard search on the metric value in the backend on a comma separated list.
The
span.domainis currently emitted as a comma separated list when there are multiple table values, but no commas are added if there single table values. This patch updates that to always add commas.For example what was the
userstable would become,users,. This is important because the wildcard search going to be added is going to do something similar to*,table_name,*. We don't want to confuse between two tables likeorgandorg_users, which can happen when we don't have the wildcard.This is a hack, but given we are changing this anyway when we get multiple values to a single metric key, I think it's fine to add as it's needed to unblock the db module GA.
#skip-changelog
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.