feat(spans): Scrub random strings in resource spans #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
reviewed
Oct 18, 2023
relay-event-normalization/src/normalize/span/description/mod.rs
Outdated
Show resolved
Hide resolved
olksdr
approved these changes
Oct 19, 2023
relay-event-normalization/src/normalize/span/description/mod.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
iker-barriocanal
approved these changes
Oct 19, 2023
| resource_script_random_path_only, | ||
| "/ERs-sUsu3/wd4/LyMTWg/Ot1Om4m8cu3p7a/QkJWAQ/FSYL/GBlxb3kB", | ||
| "resource.script", | ||
| "/*/*/*/*/*/*/*" |
There was a problem hiding this comment.
Is this string valuable?
There was a problem hiding this comment.
No, but the complexity of this PR already ballooned, so I would like to keep it as-is. If it turns out we produce high cardinality because of variable length /*, /*/*, ..., we can always reconsider.
relay-event-normalization/src/normalize/span/description/mod.rs
Outdated
Show resolved
Hide resolved
relay-event-normalization/src/normalize/span/description/mod.rs
Outdated
Show resolved
Hide resolved
jjbayer
commented
Oct 19, 2023
relay-event-normalization/src/normalize/span/description/mod.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
phacops
approved these changes
Oct 19, 2023
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR attempts to sanitize some flaws in resource span scrubbing:
chrome-extension://domains are random strings, scrub those.cdn.domain.com, writehttps://*.domain.com).=,%, ...) with**.*.See test cases for examples.