Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(globalconfig): Only report upstream errors after elapsed interval #2628

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat(globalconfig): Only report upstream errors after elapsed interval #2628

merged 2 commits into from
Oct 18, 2023

Commits on Oct 18, 2023

  1. feat(globalconfig): Only report upstream errors after elapsed interval 

    Especially during deployments, Relay sometimes faces some 503s or
timeouts from upstream, and reports an error. Having a handful of such
errors is noisy and doesn't help to identify when problems really exist.

This change introduces an interval the global config service has to wait
before reporting such errors, while consistently failing fetches.

Note that the interval does not impact other type of errors, like
failure to send requests to upstream (e.g. network is down) or global
config missing from the response. These errors are consistent and should
be reported as early as possible.
    @iker-barriocanal
    iker-barriocanal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f3fef7b View commit details
    Browse the repository at this point in the history

  2. update changelog

    @iker-barriocanal
    iker-barriocanal committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    937545d View commit details
    Browse the repository at this point in the history