fix(on-demand): Add url field to the event getter #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
changed the title
jan-auer
approved these changes
Oct 31, 2023
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ | |||
| - Disable resource link span ingestion. ([#2647](https://github.com/getsentry/relay/pull/2647)) | |||
| - Collect `http.decoded_response_content_length`. ([#2638](https://github.com/getsentry/relay/pull/2638)) | |||
| - Add TTID and TTFD tags to mobile spans. ([#2662](https://github.com/getsentry/relay/pull/2662)) | |||
| - Add support for `request.url` in the `Event` `Getter`. ([#2675](https://github.com/getsentry/relay/pull/2675)) | |||
There was a problem hiding this comment.
There is already a changelog entry above for this change, titled:
Allow access to more context fields in dynamic sampling and metric extraction.
Could you amend the changelog entry there? That entry is written in a more user-facing way.
iambriccardo
force-pushed
the
riccardo/fix/fix-extraction
branch
from
72e87cd
to
75e6e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support to the
request.urlin theEventGetter.