feat(profiling): Add optional js profile to Android profiles events

[krystofwoldrich]

• context Profiling for RN sentry-react-native#2668
• supersedes feat(profiling): Add mixed profiles (profile event V2) #2685

This PR drafts a structure of mixed profiles which enable us to ingest for example Mixed React Native and Android profiles.

[krystofwoldrich]

The PR is ready for review. Haven't tested it locally.

[olksdr]

Thanks for the PR. Overall looks ok. I left few comments which I think should be addressed before we continue.

It would be also a good idea to add more unit tests to see if the things you expect end up in the correct places.

[krystofwoldrich]

@olksdr

It would be also a good idea to add more unit tests to see if the things you expect end up in the correct places.

This code is not new, I just moved it to the Profile. There are tests for the functions in

relay/relay-profiling/src/sample.rs

Line 411 in a0e342d

, or would you like to see more here?

[Dav1dde]

I am commenting on a lot of code that was moved (only saw that after), but maybe now is a good time to clean this up a bit.

[iker-barriocanal]

This test validates the parsing doesn't fail, but we don't know if the contents are what we expect. What do you think about validating that too?

[krystofwoldrich]

Tests ensuring values are in current places are in sample.rs.

[iker-barriocanal]

The sample profile fixture seems a bit too excessive with 969KB, is this the minimal profile we can use?

[krystofwoldrich]

Yes, it's not the minimum, but it's an improvement compared to the previous roundtrip test (1,5 MB).

[Dav1dde]

Thanks for cleaning this up!

[krystofwoldrich]

Thanks for the ✅ I'm waiting for one from the profiling team and then this can be merged.