feat(protocol): Support comparisons in rule conditions on strings #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: feat(protocol): Add access to `device.model` on contexts (#2728) Revert "feat(protocol): Support comparisons in rule conditions on strings" (#2727) ref(normalization): Remove TransactionsProcessor (#2714) feat(protocol): Support comparisons in rule conditions on strings (#2721) test(normalization): Reduce span default op test scope (#2726) release: 23.11.0 fix(normalization): Restore performance score normalization (#2725)
iker-barriocanal
approved these changes
Nov 16, 2023
olksdr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a re-open of #2721.
Adds the ability to run all comparison operators (
>,>=,<,<=)on strings. This applies to dynamic sampling and metric extraction.
Since this change breaks backwards compatibility, the versioning for
metrics extraction and dynamic sampling were bumped.
Dynamic sampling configs did not have a versioning schema before. The
last breaking change introduced a
rules_v2array. To fix this, thereis now versioning built into the new config. Additionally, an
ErrorBoundaryis added around sampling configuration to preventaccidental deserialization failures.
Backwards compatibility is as follows:
rules_v2.Relates to getsentry/sentry#59896
Resolves https://github.com/getsentry/team-ingest/issues/244