Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Security Report endpoint #276

Merged
merged 46 commits into from
Nov 7, 2019
Merged

feat: Implement Security Report endpoint #276

merged 46 commits into from
Nov 7, 2019

Conversation

RaduW
Copy link
Contributor

@RaduW RaduW commented Oct 23, 2019

Security report endpoint implementation.

@RaduW RaduW changed the title feat:(document-actors) WIP started implementation of security report feat:(security-report) WIP started implementation of security report Oct 23, 2019
@RaduW RaduW changed the title feat:(security-report) WIP started implementation of security report feat:(security-report) Security Report endpoint Oct 23, 2019
@jan-auer jan-auer changed the title feat:(security-report) Security Report endpoint feat: Implement Security Report endpoint Oct 24, 2019
untitaker and others added 26 commits October 24, 2019 11:54
@untitaker
Merge remote-tracking branch 'origin/master' into feat/security-reports
6abbeee
@untitaker
ref: Avoid passing around strings as errors
9e31003
@untitaker
wip
8ccb4e1
@untitaker
wip
c6db49c
@untitaker
ref: Remove unnecessary serde(default)
014933b
@RaduW
feat:(document-actors) WIP security report
0ce479d 
endpoint
@jan-auer
ref(store): Move common code into own module
d4fa4ce
@jan-auer
ref(store): Move security report parsing into general
b8baa03
@jan-auer
fix(general): Use name for helper struct
2508bf3
@jan-auer
Merge branch 'master' into feat/security-reports
2571d2f 
* master: (26 commits)
  doc: Add documentation about the path of an event through relay (#289)
  release: 0.4.59
  meta: Changelog for 0.4.59
  ref: Set _relay_processed to true (#293)
  feat(protocol): Add valid platforms as constant (#294)
  fix(protocol): Add missing legacy alias for stacktrace (#292)
  release: 0.4.58
  meta: Add changelog for 0.4.58
  feat: Expose globbing code from Semaphore to Python (#288)
  fix: Add code comment
  fix: Normalize before datascrubbing (#290)
  feat(projects): Evict project caches after some time (#287)
  feat: Add mkdocs like in symbolicator
  ref: Add event size metrics (#286)
  test: add panic test
  ref: Selectively log internal errors to stderr (#285)
  fix(cabi): Do not ignore process_value result in scrub_event (#284)
  feat(config): Add a config value for thread counts (#283)
  fix: Refactor outcomes for parity with Sentry (#282)
  feat: Add an error boundary to parsing project states (#281)
  ...
@RaduW
feat(security-report): WIP work on the security report protocol
065c724
@RaduW
feat(security-report): WIP small fix
0460272
@jan-auer
fix: Clippy lints
f1bac6e
@jan-auer
fix(csp): Fix backfilling of the effective directive
de9b1a4
@jan-auer
feat(security_report): Add logger attribute to all events
39b95b0
@jan-auer
feat(csp): Port comment for stripe data scrubbing
4a26987
@jan-auer
feat(security_report): Add common attributes in store normalizer
43849ac
@jan-auer
feat(security_report): Extract requests from all report types
e418767
@jan-auer
feat(security_report): Implement get_tags for all report types
b4ba402
@jan-auer
feat(security_report): Implement get_culprit for all types
592b60e
@jan-auer
fix(security_report): Fix some schema differences
4449174
@jan-auer
fix(csp): Fix multiple whitespaces in culprit calculation
0700c10
@jan-auer
fix(csp): Omit scheme from http and https hostnames
641d860
@RaduW
feat(security-report): add request filtering based on content-type
630145a
@RaduW
feat(security-report): small fix (hostname in get_message)
8f431ee
@RaduW
feat(security-report): added outcomes for security report errors
9d1db33
RaduW and others added 17 commits November 5, 2019 14:16
@RaduW
feat(security-report): minor, simplify code
867eadf
@jan-auer
ref(security_report): Inline event_to_json
5b80f08
@jan-auer
ref(security_report): Move CSP logger to normalizer
7d446d8
@jan-auer
fix(csp): Ensure Referer header is only set when available
0ff2b69
@jan-auer
fix(csp): Use effective-directive when given
159d242
@jan-auer
fix(csp): Port URL unsplitting from Python
9ad0357
@jan-auer
test(csp): Port Sentry CSP event manager tests
e762b49
@jan-auer
feat(security_report): Extract release and env from query params
5a841fe
@jan-auer
test(security_report): Port remaining event manager tests from Sentry
c87b0a8
@jan-auer
fix(security_report): Respond with 201 created
9a7a635
@jan-auer
fix(endpoints): Register forward endpoint last
d372c0e
@jan-auer
fix(security_endpoint): Remove unused imports
abbdf78
@RaduW
feat(security-report): minor, simplify code
2a5a9bd
@RaduW
feat(security-report): added integration tests
82ae5f3
@RaduW
feat(security-report): WIP fixed some integration tests
db2dd16 
(still some expected output not matching)
@jan-auer
fix(security_report): Extract User-Agent instead of client_agent
7e20f5a
@jan-auer
fix(security_report): Fix URI parsing
4ff5bab
@jan-auer jan-auer marked this pull request as ready for review November 7, 2019 09:14
untitaker
untitaker approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked whether the schema matches the rfcs/specs and whether the url normalization is correct

general/src/protocol/security_report.rs Outdated Show resolved Hide resolved
@jan-auer jan-auer merged commit 4a7e898 into master Nov 7, 2019
@jan-auer jan-auer deleted the feat/security-reports branch November 7, 2019 12:38
@wpodgorski wpodgorski mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RaduW @untitaker @jan-auer