Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spans): Allow resource.img spans #2855

Merged
merged 3 commits into from
Dec 18, 2023
Merged

feat(spans): Allow resource.img spans #2855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1091b67
Extract resource.img spans
jjbayer Dec 15, 2023
7199dc0
changelog
jjbayer Dec 15, 2023
e2e7855
Merge branch 'master' into feat/spans-resource-img-all
jjbayer Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
- Allow ingestion of metrics summary on spans. ([#2823](https://github.com/getsentry/relay/pull/2823))
- Add metric_bucket data category. ([#2824](https://github.com/getsentry/relay/pull/2824))
- Org rate limit metrics per bucket. ([#2836](https://github.com/getsentry/relay/pull/2836))
- Keep only domain and extension for image resource span grouping. ([#2826](https://github.com/getsentry/relay/pull/2826))
- Emit image resource spans, grouped by domain and extension. ([#2826](https://github.com/getsentry/relay/pull/2826), [#2855](https://github.com/getsentry/relay/pull/2855))
- Parse timestamps from strings in span OpenTelemetry schema. ([#2857](https://github.com/getsentry/relay/pull/2857))

## 23.11.2
Expand Down
5 changes: 3 additions & 2 deletions relay-server/src/actors/processor/span/processing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,16 +314,17 @@ fn is_allowed(span: &Span) -> bool {
.unwrap_or_default();
op.contains("resource.script")
|| op.contains("resource.css")
|| op == "resource.img"
|| op == "http.client"
|| op.starts_with("app.")
|| op.starts_with("ui.load")
|| op.starts_with("file")
|| op.starts_with("db")
|| (op.starts_with("db")
&& !(op.contains("clickhouse")
|| op.contains("mongodb")
|| op.contains("redis")
|| op.contains("compiler"))
&& !(op == "db.sql.query" && (description.contains("\"$") || system == "mongodb"))
&& !(op == "db.sql.query" && (description.contains("\"$") || system == "mongodb")))
}

/// We do not extract or ingest spans with missing fields if those fields are required on the Kafka topic.
Expand Down
Loading