Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spans): Handle strings with escaped characters #2926

Merged
merged 4 commits into from
Jan 9, 2024
Merged

fix(spans): Handle strings with escaped characters #2926

merged 4 commits into from
Jan 9, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jan 9, 2024 •
edited
Loading

Force the ordering by span_id in the integration tests.

@phacops phacops requested a review from jjbayer January 9, 2024 15:23
@phacops phacops requested a review from a team as a code owner January 9, 2024 15:23
@phacops phacops requested a review from Dav1dde January 9, 2024 15:27
@phacops phacops enabled auto-merge (squash) January 9, 2024 15:29
jjbayer
jjbayer approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's 4 other &'a str in SpanKafkaMessage, but they're all IDs so I hope they're fine 🔥 .

@phacops phacops disabled auto-merge January 9, 2024 15:43
@phacops phacops enabled auto-merge (squash) January 9, 2024 15:51
@phacops phacops merged commit 3c6811d into master Jan 9, 2024
20 checks passed
@phacops phacops deleted the pierre/spans-handle-escaped-characters-in-description branch January 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@Dav1dde Dav1dde Awaiting requested review from Dav1dde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phacops @jjbayer