fix: Add (larger) query response size limit #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Nov 7, 2019
common/src/config.rs
Outdated
| @@ -258,6 +258,8 @@ struct Limits { | |||
| /// The total number of threads spawned will roughly be `2 * max_thread_count + 1`. Defaults to | |||
| /// the number of logical CPU cores on the host. | |||
| max_thread_count: usize, | |||
| /// The maximum size of a projectconfig query response. Defaults to 10MB | |||
| max_query_response_size: ByteSize, | |||
There was a problem hiding this comment.
We have max_api_payload_size, let's use this instead.
There was a problem hiding this comment.
Since it needs to be symmetric for query forwarding.
|
I hereby approve of the changes Jan made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actix by default would discard anything above 256kb, let's bump that to 10Mb and make it configurable