fix(cardinality): Keep sliding window updated with good cardinality items #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Feb 8, 2024
| opts = opts or {} | ||
| local key_offset = opts.skip_working_set and 1 or 0 | ||
| local offset = opts.offset or 0 | ||
| local max = opts.max |
There was a problem hiding this comment.
do you also need default for max here ? Seems like it's not always provided.
There was a problem hiding this comment.
It's a bit of a mess, but max being nil is fine, it's checked in the batches function and has a different behaviour if it's not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After checking for membership items were not added to new granules of the sliding window:
#skip-changelog