Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(cardinality): Pipeline Redis script invocations #3321

Merged
merged 3 commits into from Mar 28, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Mar 25, 2024

  • Pipelines all script invocations which use the same parent quota
  • Updates Redis to a fork which supports pipelining scripts.
  • Updates the PooledClientInner enum to box the clients because of a clippy lint large size difference between variants
  • Updates num-traits because of conflicts with the new Redis client version which has a higher min version
error: large size difference between variants
  --> relay-redis/src/real.rs:75:1
   |
75 | / enum PooledClientInner {
76 | |     Cluster(PooledConnection<redis::cluster::ClusterClient>),
   | |     -------------------------------------------------------- the largest variant contains at least 408 bytes
77 | |     Single(PooledConnection<redis::Client>),
   | |     --------------------------------------- the second-largest variant contains at least 200 bytes
78 | | }
   | |_^ the entire enum is at least 408 bytes

Requires: #3313

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner March 25, 2024 15:38
@Dav1dde Dav1dde self-assigned this Mar 25, 2024
@Dav1dde Dav1dde mentioned this pull request Mar 25, 2024
@Dav1dde Dav1dde changed the title ref(cardinality): Pipelines Redis script invocations ref(cardinality): Pipeline Redis script invocations Mar 25, 2024
relay-cardinality/src/redis/script.rs Show resolved Hide resolved
relay-cardinality/src/redis/script.rs Show resolved Hide resolved
relay-cardinality/src/redis/limiter.rs Show resolved Hide resolved
relay-cardinality/src/redis/limiter.rs Show resolved Hide resolved
Base automatically changed from dav1d/feat/name-card to master March 28, 2024 09:32
@Dav1dde Dav1dde enabled auto-merge (squash) March 28, 2024 09:51
@Dav1dde Dav1dde merged commit b60beb5 into master Mar 28, 2024
20 checks passed
@Dav1dde Dav1dde deleted the dav1d/ref/pipeline-card branch March 28, 2024 10:10
jan-auer added a commit that referenced this pull request Mar 28, 2024
* master:
  ref(cardinality): Pipeline Redis script invocations (#3321)
  ref(normalization): Remove StoreProcessor (#3097)
  feat(cardinality): Implement name based cardinality limits (#3313)
  instr(kafka): Tag existing metrics with variant (#3352)
  instr(kafka): More broker stats (#3349)
  instr(kafka): Improve produce error handling (#3351)
  feat(schema): Allow integers as username (#3328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants